Skip to content

AVRO-3076: Fix incorrect Javadoc regarding custom coder defaults #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanSkraba merged 1 commit into from
Jun 17, 2022
Merged

AVRO-3076: Fix incorrect Javadoc regarding custom coder defaults #1715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ public class ReflectData extends SpecificData {

private static final String STRING_OUTER_PARENT_REFERENCE = "this$0";

/**
* Always false since custom coders are not available for {@link ReflectData}.
*/
@Override
public boolean useCustomCoders() {
return false;
Expand Down
2 changes: 1 addition & 1 deletion lang/java/avro/src/main/java/org/apache/avro/specific/SpecificData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public static <T> SpecificData getForClass(Class<T> c) {

/**
* Retrieve the current value of the custom-coders feature flag. Defaults to
* <code>true</code>, but this default can be overridden using the system
* <code>false</code>, but this default can be overridden using the system
* property <code>org.apache.avro.specific.use_custom_coders</code>, and can be
* set dynamically by {@link SpecificData#useCustomCoders()}. See <a
* href="https://avro.apache.org/docs/current/gettingstartedjava.html#Beta+feature:+Generating+faster+code"Getting
Expand Down