AVRO-3076: Fix incorrect Javadoc regarding custom coder defaults #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opwvhk
approved these changes
Jun 10, 2022
RyanSkraba
approved these changes
Jun 17, 2022
Contributor
RyanSkraba
left a comment
RyanSkraba
left a comment
There was a problem hiding this comment.
LGTM -- thanks for keeping these comments truthful!
RyanSkraba
pushed a commit
that referenced
this pull request
Jun 17, 2022
czf
pushed a commit
to czf/avro
that referenced
this pull request
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
useCustomCoders()documentation forSpecificDataandReflectData. In the case ofSpecificDatait specifies the correct default, and in the case ofReflectDatait overrides the documentation it inherited fromSpecificDatain order to clarify that custom coders are unsupported.Jira
Tests
This PR only includes documentation updates.