ARROW-10461: [Rust] Fix offset bug in remainder bits #8571
Conversation
vertexclique
left a comment
vertexclique
left a comment
There was a problem hiding this comment.
I would like to have documentation for the whole code and make it understandable. Including the code that is using this in the Array method call, tests, expectations, and briefly what it does.
|
|
||
| assert_eq!(63, bitchunks.remainder_len()); | ||
| assert_eq!( | ||
| 0b01000000_00111111_11000000_00111111_11000000_00111111_11000000_00111111, |
There was a problem hiding this comment.
Why this forms these bit pattern? How a reader can be ensure that it is forming the correct pattern while reading?
|
@jorgecarleitao @nevi-me Can you take a look at this bugfix? |
|
@jhorstmann , bit operations is one of my weaknesses; I can't review this due to my lack of knowledge on that topic. |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me. 👍 for the tests
rust/arrow-flight/Cargo.toml
Outdated
| [dependencies] | ||
| arrow = { path = "../arrow", version = "3.0.0-SNAPSHOT" } | ||
| tonic = "0.3" | ||
| tonic = "0.3.1" |
There was a problem hiding this comment.
I wonder if there is some reason to upgrade tonic in this same PR?
There was a problem hiding this comment.
I had compilation failures otherwise, but it's strange that other PRs do not seem to have the same issue. I'll check again and maybe move this to a separate PR.
There was a problem hiding this comment.
Removed the dependency again and CI still works, not sure what the issue was locally.
|
FYI @jorgecarleitao / @nevi-me I think we should merge this PR. |
|
@nevi-me @alamb @jorgecarleitao I had a quick chat with @vertexclique and we think we can merge this PR with the bugfix first and then rebase and integrate his refactoring. Those PRs shouldn't block each other. |
|
I agree @jhorstmann -- I think we should merge this. Update: the bits came through and I have merged this PR. FYI @andygrove @nevi-me and @jorgecarleitao |
|
@jhorstmann thanks a lot for this fix! @alamb, congrats on your push!!!!! 🎉 🎉 🎉 🎉 🎉 |
6 participants
No description provided.