Skip to content

ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+ #8216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trxcllnt wants to merge 5 commits into from
Closed

ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+ #8216

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a25f690
fix typescript 3.9+ compiler errors
trxcllnt Sep 18, 2020
913460c
bump node to 14
trxcllnt Sep 18, 2020
b769105
update package-lock.json
trxcllnt Sep 18, 2020
63264ce
update node github workflow name
trxcllnt Sep 18, 2020
86780cb
update dependencies so `npm audit` reports 0 vulnerabilities
trxcllnt Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ LLVM=10
CLANG_TOOLS=8
RUST=nightly-2020-04-22
GO=1.12
NODE=11
NODE=14
Comment thread
trxcllnt marked this conversation as resolved.
MAVEN=3.5.4
JDK=8
PANDAS=latest
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ env:
jobs:

docker:
name: AMD64 Debian 10 NodeJS 11
name: AMD64 Debian 10 NodeJS 14
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
steps:
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [11]
node: [14]
steps:
- name: Checkout Arrow
uses: actions/checkout@v2
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
# strategy:
# fail-fast: false
# matrix:
# node: [11]
# node: [14]
# steps:
# - name: Checkout Arrow
# uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion ci/docker/conda-integration.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ FROM ${repo}:${arch}-conda-cpp

ARG arch=amd64
ARG maven=3.5
ARG node=11
ARG node=14
ARG jdk=8
ARG go=1.12

Expand Down
2 changes: 1 addition & 1 deletion ci/docker/debian-10-js.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# under the License.

ARG arch=amd64
ARG node=11
ARG node=14
FROM ${arch}/node:${node}

ENV NODE_NO_WARNINGS=1
Expand Down
2 changes: 1 addition & 1 deletion ci/docker/linux-apt-docs.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ RUN /arrow/ci/scripts/util_download_apache.sh \
ENV PATH=/opt/apache-maven-${maven}/bin:$PATH
RUN mvn -version

ARG node=11
ARG node=14
RUN wget -q -O - https://deb.nodesource.com/setup_${node}.x | bash - && \
apt-get install -y nodejs && \
apt-get clean && \
Expand Down
2 changes: 1 addition & 1 deletion js/gulp/closure-task.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const createClosureArgs = (entry_point, externs) => ({
entry_point,
third_party: true,
warning_level: `QUIET`,
dependency_mode: `STRICT`,
dependency_mode: `PRUNE`,
rewrite_polyfills: false,
module_resolution: `NODE`,
// formatting: `PRETTY_PRINT`,
Expand Down
Loading