Skip to content

ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+ #8216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trxcllnt wants to merge 5 commits into from
Closed

ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+ #8216

trxcllnt wants to merge 5 commits into from

Conversation

@trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Sep 18, 2020

  • Upgrades to TypeScript 4.0.2
  • Fixes typings for TypeScript versions 3.9+

Closes https://issues.apache.org/jira/browse/ARROW-8394

@github-actions
Copy link

github-actions bot commented Sep 18, 2020

https://issues.apache.org/jira/browse/ARROW-8394

@trxcllnt
Copy link
Contributor Author

trxcllnt commented Sep 18, 2020 •
edited
Loading

@kszucs recent node versions changed behavior of one of the stream properties we're testing, so node 11 will fail now.

I tried updating all references to node v11, but I'm not sure how to update the Ursabot / AMD64 Debian 9 NodeJS 11 build. Is this something we can update and include in this PR?

@kszucs
Copy link
Member

kszucs commented Sep 18, 2020

Thanks for the update! I'll handle the ursabot builder.

@TheNeuralBit
Copy link
Member

TheNeuralBit commented Sep 18, 2020

Thanks Paul! I should have time to take a look over the weekend

TheNeuralBit
TheNeuralBit reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trxcllnt! Couple questions/comments

@kszucs
Copy link
Member

kszucs commented Sep 23, 2020

@ursabot build

@kszucs
Copy link
Member

kszucs commented Sep 23, 2020

The Ursabot / AMD64 Debian 9 NodeJS 11 builder is no longer enabled in favor of Ursabot / AMD64 Debian 9 NodeJS 14, so it should be good to go from the buildbot side.

@nealrichardson
Copy link
Member

nealrichardson commented Oct 5, 2020

@trxcllnt Is this ready to merge?

@trxcllnt
Copy link
Contributor Author

trxcllnt commented Oct 5, 2020

@nealrichardson yeah I believe so

@tconkling
Copy link

tconkling commented Oct 5, 2020

Thanks a lot for your work on this, @trxcllnt! Really excited for this to land in a release.

@nevi-me nevi-me mentioned this pull request Dec 3, 2020
Closed
@asfimport asfimport mentioned this pull request Jan 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheNeuralBit TheNeuralBit TheNeuralBit left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trxcllnt @kszucs @TheNeuralBit @nealrichardson @tconkling