-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-45813: [Docs] Enable discussions #45811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Let's open an issue for better visibility an openness. This doesn't change any features but this is a change that affects users and developers. |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @kou, let's create an issue to track this.
|
Also, it seems you pushed your branch to the |
This caught my typo with |
|
|
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this now that the vote has passed
|
Result to the vote: |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9c41cdc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
### Rationale for this change See: https://lists.apache.org/thread/wxtcq0xtfcr2rrdlowo93qqvpvhb10pl ### What changes are included in this PR? - turn on discussions - turn on existing features - this is required as the recently updated backend of .asf.yaml will now turn features of that have previously been turned on manually and are not part of the current config - protect main against force pushes - this is imo a basic security feature. any additional rules would need to work with our current release process that currently requires direct pushes to main ### Are these changes tested? The asf yaml parser will send an email if the config is broken, this only works when the change is made from within the repo and not a fork. ### Are there any user-facing changes? Yes, discussions are now available. * GitHub Issue: apache#45813 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Rationale for this change
See: https://lists.apache.org/thread/wxtcq0xtfcr2rrdlowo93qqvpvhb10pl
What changes are included in this PR?
Are these changes tested?
The asf yaml parser will send an email if the config is broken, this only works when the change is made from within the repo and not a fork.
Are there any user-facing changes?
Yes, discussions are now available.