Skip to content

GH-43175: [C++] Skip not Emscripten ready tests in CSV tests #43724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Aug 17, 2024
Merged

GH-43175: [C++] Skip not Emscripten ready tests in CSV tests #43724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/scripts/cpp_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ case "$(uname)" in
;;
esac

if [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
if [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
n_jobs=1 # avoid spurious fails on emscripten due to loading too many big executables
fi

Expand Down
11 changes: 11 additions & 0 deletions cpp/src/arrow/csv/column_decoder_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ class NullColumnDecoderTest : public ColumnDecoderTest {
}

void TestThreaded() {
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Test requires threading support";
#endif
constexpr int NITERS = 10;
auto type = int32();
MakeDecoder(type);
Expand Down Expand Up @@ -257,6 +260,10 @@ class TypedColumnDecoderTest : public ColumnDecoderTest {
}

void TestThreaded() {
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Test requires threading support";
#endif

constexpr int NITERS = 10;
auto type = uint32();
MakeDecoder(type, default_options);
Expand Down Expand Up @@ -305,6 +312,10 @@ class InferringColumnDecoderTest : public ColumnDecoderTest {
}

void TestThreaded() {
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Test requires threading support";
#endif

constexpr int NITERS = 10;
auto type = float64();
MakeDecoder(default_options);
Expand Down
5 changes: 5 additions & 0 deletions cpp/src/arrow/csv/converter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,11 @@ TEST(TimestampConversion, UserDefinedParsers) {
}

TEST(TimestampConversion, UserDefinedParsersWithZone) {
#ifdef __EMSCRIPTEN__
GTEST_SKIP() << "Test temporarily disabled due to emscripten bug "
"https://github.com/emscripten-core/emscripten/issues/20467";
#endif

auto options = ConvertOptions::Defaults();
auto type = timestamp(TimeUnit::SECOND, "America/Phoenix");

Expand Down