Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Aug 16, 2024

Rationale for this change

We can't use thread nor %z on Emacripten. Some CSV tests use them.

What changes are included in this PR?

Skip CSV tests that use thread or %z.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Aug 16, 2024

@github-actions crossbow submit -g cpp

@github-actions
Copy link

⚠️ GitHub issue #43175 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

Revision: d54502a

Submitted crossbow builds: ursacomputing/crossbow @ actions-58288f5ac1

Task Status
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

@kou
Copy link
Member Author

kou commented Aug 17, 2024

+1

@kou kou merged commit 49be60f into apache:main Aug 17, 2024
@kou kou removed the awaiting committer review Awaiting committer review label Aug 17, 2024
@kou kou deleted the cpp-csv-test-no-thread branch August 17, 2024 02:50
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 49be60f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant