GH-35458: [C++][Benchmarking] Require Google Benchmark 1.6.1 or later #35459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… later Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later.
|
|
github-actions
bot
added
Component: C++
awaiting committer review
wjones127
approved these changes
May 8, 2023
github-actions
bot
added
awaiting merge
|
Benchmark runs are scheduled for baseline = ad43544 and contender = aa8ffbe. aa8ffbe is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
… later (apache#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
… later (apache#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
… later (apache#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
raulcd
pushed a commit
that referenced
this pull request
May 31, 2023
…#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Google Benchmark 1.6.1 added
benchmark::MemoryManager::Stop(Result&)and deprecatedbenchmark::MemoryManager::Stop(Result*).Google Benchmark 1.8.0 dropped deprecated
benchmark::MemoryManager::Stop(Result*).Google Benchmark deprecated
DoNotOptimize(const &):google/benchmark#1493
What changes are included in this PR?
We can always use
benchmark::MemoryManager::Stop(Result&)by requiring Google Benchmark 1.6.1 or later.Don't use deprecated
DoNotOptimize(const &).Are these changes tested?
Yes.
Are there any user-facing changes?
No.