-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][Benchmarking] Can't build with Google Benchmark 1.8.0 #35458
Comments
kou
added a commit
to kou/arrow
that referenced
this issue
May 6, 2023
… later Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later.
kou
added a commit
that referenced
this issue
May 9, 2023
…#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
… later (apache#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
… later (apache#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
… later (apache#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
raulcd
pushed a commit
that referenced
this issue
May 31, 2023
…#35459) ### Rationale for this change Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark 1.8.0 dropped deprecated `benchmark::MemoryManager::Stop(Result*)`. Google Benchmark deprecated `DoNotOptimize(const &)`: google/benchmark#1493 ### What changes are included in this PR? We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later. Don't use deprecated `DoNotOptimize(const &)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #35458 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
https://github.com/apache/arrow/actions/runs/4897907287/jobs/8746494685?pr=35454#step:6:1881
google/benchmark@9714eb8 is related.
Component(s)
Benchmarking, C++
The text was updated successfully, but these errors were encountered: