Skip to content

GH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_ARRAY #34955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wjones127 merged 2 commits into from
Apr 8, 2023
Merged

GH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_ARRAY #34955

wjones127 merged 2 commits into from
Apr 8, 2023

Conversation

@mapleFU
Copy link
Member

@mapleFU mapleFU commented Apr 7, 2023 •
edited by github-actions bot
Loading

Rationale for this change

According to #34323 . DELTA_LENGTH_BYTE_ARRAY is much more slower. So do some optimizations.

What changes are included in this PR?

Some tiny changes

Are these changes tested?

Are there any user-facing changes?

@mapleFU mapleFU requested a review from wjones127 as a code owner April 7, 2023 03:10
@mapleFU
Copy link
Member Author

mapleFU commented Apr 7, 2023

@rok @wjones127 @wgtmac

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

wjones127
wjones127 requested changes Apr 7, 2023
View reviewed changes
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 7, 2023
@mapleFU
Copy link
Member Author

mapleFU commented Apr 8, 2023

@wjones127 comment resolved, you can take a look when you have spare time :)

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 8, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Apr 8, 2023
@wjones127 wjones127 merged commit 28ca876 into apache:main Apr 8, 2023
@mapleFU mapleFU deleted the parquet/zero-copy-optimize branch April 8, 2023 19:32
@ursabot
Copy link

ursabot commented Apr 9, 2023

Benchmark runs are scheduled for baseline = 9833a0a and contender = 28ca876. 28ca876 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.68% ⬆️0.42%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.89% ⬆️0.43%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 28ca876d ec2-t3-xlarge-us-east-2
[Finished] 28ca876d test-mac-arm
[Finished] 28ca876d ursa-i9-9960x
[Finished] 28ca876d ursa-thinkcentre-m75q
[Finished] 9833a0aa ec2-t3-xlarge-us-east-2
[Finished] 9833a0aa test-mac-arm
[Finished] 9833a0aa ursa-i9-9960x
[Finished] 9833a0aa ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@mapleFU @liujiacheng777
apacheGH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_AR…
5f3d97d 
…RAY (apache#34955)

### Rationale for this change

According to apache#34323 . DELTA_LENGTH_BYTE_ARRAY is much more slower. So do some optimizations.

### What changes are included in this PR?

Some tiny changes

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34335

Authored-by: mwish <[email protected]>
Signed-off-by: Will Jones <[email protected]>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@mapleFU @ArgusLi
apacheGH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_AR…
ed630c7 
…RAY (apache#34955)

### Rationale for this change

According to apache#34323 . DELTA_LENGTH_BYTE_ARRAY is much more slower. So do some optimizations.

### What changes are included in this PR?

Some tiny changes

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34335

Authored-by: mwish <[email protected]>
Signed-off-by: Will Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjones127 wjones127 wjones127 approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++ Component: Parquet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++][Parquet] Improve the performance for Decoding DELTA_LENGTH_BYTE_ARRAY

3 participants

@mapleFU @ursabot @wjones127