Skip to content

ARROW-2595: [Plasma] Use map.find instead of operator[] to avoid producing garbage data #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wumuzi520 wants to merge 1 commit into from
Closed

ARROW-2595: [Plasma] Use map.find instead of operator[] to avoid producing garbage data #2056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions cpp/src/plasma/store.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,14 @@ void PlasmaStore::return_from_get(GetRequest* get_req) {
// tables if it is present there. It should only be present there if the get
// request timed out.
for (ObjectID& object_id : get_req->object_ids) {
auto& get_requests = object_get_requests_[object_id];
// Erase get_req from the vector.
auto it = std::find(get_requests.begin(), get_requests.end(), get_req);
if (it != get_requests.end()) {
get_requests.erase(it);
auto object_request_iter = object_get_requests_.find(object_id);
if (object_request_iter != object_get_requests_.end()) {
auto& get_requests = object_request_iter->second;
// Erase get_req from the vector.
auto it = std::find(get_requests.begin(), get_requests.end(), get_req);
if (it != get_requests.end()) {
get_requests.erase(it);
}
}
}
// Remove the get request.
Expand Down