Skip to content

Comments

ARROW-2595: [Plasma] Use map.find instead of operator[] to avoid producing garbage data#2056

Closed
wumuzi520 wants to merge 1 commit intoapache:masterfrom
ant-tech-alliance:dev_slz
Closed

ARROW-2595: [Plasma] Use map.find instead of operator[] to avoid producing garbage data#2056
wumuzi520 wants to merge 1 commit intoapache:masterfrom
ant-tech-alliance:dev_slz

Conversation

@wumuzi520
Copy link

  • Problem

    • Using object_get_requests_[object_id] will produce a lot of garbage data in PlasmaStore::return_from_get. During the measurement process, we found that there was a lot of memory growth in this point.
  • Solution

    • Use iterator instead of operator []

Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@codecov-io
Copy link

Codecov Report

Merging #2056 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2056      +/-   ##
==========================================
+ Coverage   87.44%   87.44%   +<.01%     
==========================================
  Files         189      189              
  Lines       29374    29376       +2     
==========================================
+ Hits        25686    25688       +2     
  Misses       3688     3688
Impacted Files Coverage Δ
cpp/src/plasma/store.cc 88.7% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e237918...ccaab50. Read the comment docs.

@pcmoritz pcmoritz changed the title Use map.find instead of operator[] to avoid producing garbage data ARROW-2595: Use map.find instead of operator[] to avoid producing garbage data May 17, 2018
@pcmoritz
Copy link
Contributor

@wumuzi520 Thanks for the contribution! Can you create an account in JIRA so I can assign the issue to you?

@pcmoritz pcmoritz changed the title ARROW-2595: Use map.find instead of operator[] to avoid producing garbage data ARROW-2595: [Plasma] Use map.find instead of operator[] to avoid producing garbage data May 17, 2018
@pcmoritz pcmoritz closed this in df20683 May 17, 2018
@wesm
Copy link
Member

wesm commented Jul 27, 2018

@wumuzi520 could you create a JIRA account and let us know your user ID? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants