Skip to content

ARROW-17732: [Docs][Java] Add minimal JDBC driver docs #14137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lidavidm merged 2 commits into from
Oct 19, 2022
Merged

ARROW-17732: [Docs][Java] Add minimal JDBC driver docs #14137

lidavidm merged 2 commits into from
Oct 19, 2022

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Sep 15, 2022

No description provided.

@lidavidm
Copy link
Member Author

lidavidm commented Sep 15, 2022

Accompanies apache/arrow-site#236

Rendered:

image

@lidavidm lidavidm mentioned this pull request Sep 15, 2022
Closed
@nealrichardson
Copy link
Member

nealrichardson commented Sep 15, 2022

@lidavidm I think ARROW-17332 is not the right jira

@lidavidm lidavidm changed the title ARROW-17332: [Docs][Java] Add minimal JDBC driver docs ARROW-17732: [Docs][Java] Add minimal JDBC driver docs Sep 15, 2022
@lidavidm
Copy link
Member Author

lidavidm commented Sep 15, 2022

whoops, that should've been 17732, thanks

@github-actions
Copy link

github-actions bot commented Sep 15, 2022

https://issues.apache.org/jira/browse/ARROW-17332

@github-actions
Copy link

github-actions bot commented Sep 15, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions
Copy link

github-actions bot commented Sep 15, 2022

https://issues.apache.org/jira/browse/ARROW-17732

@lidavidm
Copy link
Member Author

lidavidm commented Sep 18, 2022

CC @jduo, does this look reasonable as a basic landing page?

@lidavidm
Copy link
Member Author

lidavidm commented Oct 12, 2022

@davisusanibar @lwhite1 could one of you give this a skim? It would be good to have documentation for our shiny new driver.

lwhite1
lwhite1 reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@lwhite1 lwhite1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. Otherwise LGTM.

docs/source/java/flight_sql_jdbc_driver.rst Outdated
Copy link
Contributor

@lwhite1 lwhite1 Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just me but I find these URI format definitions to be a little cryptic. Maybe include an example string with a couple of parameters so people have something concrete to refer to?

Copy link
Member Author

@lidavidm lidavidm Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea. I added an example with some prose to explain the parameters.

@lidavidm lidavidm merged commit 5984d8a into apache:master Oct 19, 2022
@lidavidm lidavidm deleted the arrow-17732 branch October 19, 2022 13:17
@asfimport asfimport mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lwhite1 lwhite1 lwhite1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lidavidm @nealrichardson @lwhite1