Skip to content

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Sep 14, 2022

No description provided.

@github-actions
Copy link

@lidavidm
Copy link
Member Author

Rendered

image

@lidavidm
Copy link
Member Author

See apache/arrow#14137

@lidavidm
Copy link
Member Author

Added a reference to the ODBC driver as well.

@lidavidm lidavidm marked this pull request as ready for review September 16, 2022 15:57
@rapinderj33
Copy link

rapinderj33 commented Oct 14, 2022

Hi David, for the second paragraph under "Why JDBC", I think talking about ADBC takes away from the JDBC discussion and may confuse the user.

Also whenever you mention Dremio can you add this link to it: https://www.dremio.com/resources/guides/apache-arrow/.

Also under Getting involved can you add this phrase: "refer to Dremio's Apache Arrow guide" and then this link: (https://www.dremio.com/resources/guides/apache-arrow/)

Also after saying after courtesy of the grant by Dremio.... Can the next sentence include our tag line: "Dremio, the easy and open data lakehouse platform. "

advantage of JDBC to interoperate generically with multiple databases.
An Arrow-native database may still wish to be accessible to all of
this existing software, without having to implement multiple client
interfaces itself.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about adding a sentence at the end saying:

To learn more about the trade-offs and when to use the Arrow Flight SQL JDBC driver vs the Arrow Flight SQL native client libraries, you can watch this section of Dremio's presentation on it

and Flight SQL, and increases the reach of Arrow-based applications.
Additionally, an [ODBC driver implementation][dremio-odbc] based on
Flight SQL is also available, though it is not part of the Arrow
project.
Copy link

@jasonhughes248 jasonhughes248 Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make that last sentence "Dremio has also made an [Arrow Flight SQL ODBC driver][dremio-odbc] available to the Arrow community, though it is not part of the Arrow project yet due to dependency licensing issues."

@jasonhughes248
Copy link

Hi David, made a couple comments. looks good!

@lidavidm
Copy link
Member Author

Rendered

image

Thanks for the feedback. Changes:

  • Reorganized material to flow better, and emphasize the unique advantages of Flight SQL
  • Consolidated "Background" into the intro
  • Removed broken link since docs PR is not yet reviewed
  • I want to be careful with marketing taglines as this post is meant to be about the Arrow ecosystem, but I added a tagline describing Dremio as a data lakehouse platform. @rapinderj33 is that ok?
  • And I'm not sure if you wanted to link every mention of Dremio to the Arrow guide specifically, but I put a reference to that alongside the rest of the documentation.
  • Changed ADBC to be a minor reference
  • Link to Jason's presentation
  • Mention the current licensing issues for the ODBC driver

@lidavidm lidavidm force-pushed the arrow-17731 branch 2 times, most recently from c8ca094 to 6f92711 Compare October 18, 2022 12:26
@lidavidm
Copy link
Member Author

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor notes but otherwise LGTM

database can support JDBC users without implementing additional APIs
or its own JDBC driver.

[^1]: Despite the name, Flight SQL is **not** a SQL dialect, nor is it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems important and worth reiterating--maybe put it in the paragraph itself instead of a footnote/


The JDBC driver was merged for the Arrow 10.0.0 release, and the
[source code][impl] can be found in the Arrow repository. Once Arrow
10.0.0 is released (which is planned for October/November 2022),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise this now that the RC is happening? And/or consider holding to publish with the release announcement--"you can check it out now" is a better call-to-action than "someday soon it will be released"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense - and we can patch up the release notes afterwards as well.

@lidavidm
Copy link
Member Author

@rapinderj33 we'll push this once 10.0.0 officially releases, and I'll patch in download links and fix the date/time on the post before that. The vote is still underway, so hopefully that will be soon.

@lidavidm
Copy link
Member Author

Will go out 2022-11-01

@lidavidm lidavidm closed this in e005501 Nov 1, 2022
@lidavidm lidavidm deleted the arrow-17731 branch November 1, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants