ARROW-587: Add fix version to PR merge tool #1248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id2b5e0a9fd45e44625a8c4094f61d41ed272234e
Change-Id: I901e62a57a1a3dd38a346f4a4bde79bd347c7d2d
Member
Author
|
Tried merging #1245 but there was a bug. Will keep at it until this script is right |
Change-Id: I6e779d4d79927673f066db329decdf010ea5f4e9
Change-Id: I1aeee2e73e34819493837e1388bab57dc7ac8067
Member
Author
|
OK, this is good to go |
xhochy
approved these changes
Oct 26, 2017
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1
Are these fixes relevant for parquet-cpp, too? Can you port them there?
Member
Author
|
Yeah, we should do that because parquet-cpp is Python 2 only |
Member
Author
|
opened ARROW-1739 about fixing the broken build (unrelated to this patch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was ported from parquet-mr/parquet-cpp and modified to work in Python 2 and 3