ARROW-1484: [C++/Python] Implement casts between date, time, timestamp units #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib64bf5d57bfec374d7b7e6d2fd5954a73b471a56
Change-Id: I71d6783acf208ec4b66f91ff6f5a857ac19b80ac
Change-Id: I1defe0410b2aada7eebf77f4e61ea34634836498
Change-Id: Ic3dd593eb8876f4171cdd2737d022b3731a0dae9
Change-Id: I6852192011b257119bc5c8832607f4d9ba191073
Change-Id: Ied9180ef02a6835662911faabed70e986729ec86
Change-Id: Id4613af068fc31371ac530920f2938d9a4231416
Change-Id: Iedc2f14ec80146fa808c9935368f266cb06138a5
Change-Id: I7a248251372c4cb86871b4c569f064de4c250670
BryanCutler
reviewed
Oct 25, 2017
| vector<int64_t> v8 = {0, 100123, 200456, 1123, 2456}; | ||
| vector<int64_t> e8 = {0, 100, 200, 1, 2}; | ||
|
|
||
| options.allow_time_truncate = true; |
Member
There was a problem hiding this comment.
Does this option need to be set in pyarrow to prevent an error when truncating?
Member
Author
There was a problem hiding this comment.
Thanks for catching. I'll make safe=True set this option http://arrow.apache.org/docs/python/generated/pyarrow.lib.Array.html#pyarrow.lib.Array.cast
Change-Id: Ie55185196ac7d417ad31892eae14e28d0cab516f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several JIRAs here that made sense to tackle together:
This also fixes bugs relating to ignoring the offset in sliced arrays in some of the cast kernel implementations.
cc @BryanCutler @xhochy @cpcloud