[CPP] Add missing metadata on Arrow schemas returned by Flight SQL #11999 #12002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
jcralmeida
force-pushed
the
flight-sql-cpp-column-metadata
branch
from
c0d4c51 to
e6891f2
Compare
lidavidm
reviewed
Dec 27, 2021
|
|
||
| /// \brief Constant variable to hold the value of the key that | ||
| /// will be used in the KeyValueMetadata class. | ||
| static const char* CATALOG_NAME; |
Member
There was a problem hiding this comment.
nit: constants should be named kCatalogName according to the style guide
|
|
||
| #include <utility> | ||
|
|
||
| namespace { |
Member
There was a problem hiding this comment.
nit: the anonymous namespace could probably be nested into the arrow::flight::sql namespace below
|
|
||
| /// \brief Return the catalog name set in the KeyValueMetadata. | ||
| /// \return The catalog name. | ||
| arrow::Result<std::string> GetCatalogName(); |
Contributor
Author
|
Closed this pull request because both implementation JAVA and C++ are now in the same Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add an auxiliary class FlightSqlColumnMetadata meant to read and write known metadata for Arrow schema fields, such as CATALOG_NAME, SCHEMA_NAME, TABLE_NAME, PRECISION, SCALE, IS_AUTO_INCREMENT, IS_CASE_SENSITIVE, IS_READ_ONLY and IS_SEARCHABLE.