Skip to content

ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonkeane wants to merge 5 commits into from
Closed

ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift #10430

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe66fe0
bundle source for gRPC and protobuf
jonkeane Jun 1, 2021
acc3f09
re-alpha
jonkeane Jun 1, 2021
ae9c62d
add 20.04 docs build
jonkeane Jun 1, 2021
c0b8747
clarify that the docs is the default ubuntu version
jonkeane Jun 1, 2021
f7ea8ec
PR comments
jonkeane Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ci/docker/ubuntu-20.04-cpp.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ RUN apt-get update -y -q && \
libcurl4-openssl-dev \
libgflags-dev \
libgoogle-glog-dev \
libgrpc++-dev \

@kou kou Jun 2, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to install libgrpc++-dev and protobuf-compiler-grpc when we use bundled gRPC and ProtoBuf.

@jonkeane jonkeane Jun 2, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thanks for that! Cruft leftover from me trying to get it working

liblz4-dev \
libprotobuf-dev \
libprotoc-dev \
Expand All @@ -88,6 +89,7 @@ RUN apt-get update -y -q && \
ninja-build \
pkg-config \
protobuf-compiler \
protobuf-compiler-grpc \
rapidjson-dev \
tzdata \
wget && \
Expand Down Expand Up @@ -129,8 +131,10 @@ ENV ARROW_BUILD_TESTS=ON \
ARROW_WITH_ZSTD=ON \
AWSSDK_SOURCE=BUNDLED \
GTest_SOURCE=BUNDLED \
gRPC_SOURCE=BUNDLED \
ORC_SOURCE=BUNDLED \
PARQUET_BUILD_EXAMPLES=ON \
PARQUET_BUILD_EXECUTABLES=ON \
PATH=/usr/lib/ccache/:$PATH \
Protobuf_SOURCE=BUNDLED \
PYTHON=python3
6 changes: 6 additions & 0 deletions dev/tasks/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,12 @@ tasks:
UBUNTU: "20.10"
run: ubuntu-docs

test-ubuntu-default-docs:
ci: azure
template: docker-tests/azure.linux.yml
params:
run: ubuntu-docs

############################## vcpkg tests ##################################

test-build-vcpkg-win:
Expand Down