-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift #10430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR resolves building on Ubuntu 20.04 which is our default though the crossbow build in tasks is on 20.10 which has one of these additions, but also a newer protobuff so that's not needed to be bundled. We also might consider not adding these lines but making clear in the docker compose file that |
|
I ran this on crossbow (locally since the GH actions comment bot isn't working right now https://issues.apache.org/jira/browse/ARROW-12919) and the only ubuntu crossbow builds that failed were all ones that have other current nightly failures. I've also added a defaults docs nightly to catch if we have a mismatch like this in the future. |
| libcurl4-openssl-dev \ | ||
| libgflags-dev \ | ||
| libgoogle-glog-dev \ | ||
| libgrpc++-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to install libgrpc++-dev and protobuf-compiler-grpc when we use bundled gRPC and ProtoBuf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, thanks for that! Cruft leftover from me trying to get it working
jorgecarleitao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @jonkeane !
No description provided.