Skip to content

Conversation

@jonkeane
Copy link
Member

@jonkeane jonkeane commented Jun 1, 2021

No description provided.

@jonkeane jonkeane changed the title ARROW-12915 [Release] Build of ubuntu-docs is failing on thrift ARROW-12915: [Release] Build of ubuntu-docs is failing on thrift Jun 1, 2021
@jonkeane
Copy link
Member Author

jonkeane commented Jun 1, 2021

This PR resolves building on Ubuntu 20.04 which is our default though the crossbow build in tasks is on 20.10 which has one of these additions, but also a newer protobuff so that's not needed to be bundled.

We also might consider not adding these lines but making clear in the docker compose file that ubuntu-docs will not work with Ubuntu 20.04 and instead should always be build on 20.10

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

@jonkeane
Copy link
Member Author

jonkeane commented Jun 1, 2021

I ran this on crossbow (locally since the GH actions comment bot isn't working right now https://issues.apache.org/jira/browse/ARROW-12919) and the only ubuntu crossbow builds that failed were all ones that have other current nightly failures.

I've also added a defaults docs nightly to catch if we have a mismatch like this in the future.

libcurl4-openssl-dev \
libgflags-dev \
libgoogle-glog-dev \
libgrpc++-dev \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to install libgrpc++-dev and protobuf-compiler-grpc when we use bundled gRPC and ProtoBuf.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thanks for that! Cruft leftover from me trying to get it working

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @jonkeane !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants