Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aws/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1526,7 +1526,8 @@ mod tests {
.with_region("region")
.with_bucket_name("bucket_name")
.with_allow_http(true)
.with_proxy_url("asdf://example.com")
// use invalid url
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect, but don't know, that this change is required by

the test expects the proxy config to fail, but after the reqwest upgrade it was passing

.with_proxy_url("dxx:ddd\\example.com")
.build()
.unwrap_err()
.to_string();
Expand Down
2 changes: 1 addition & 1 deletion src/client/retry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ mod tests {
assert_eq!(r.status(), StatusCode::OK);

// Handles redirect loop
for _ in 0..10 {
for _ in 0..11 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change is needed due to seanmonstar/reqwest#2664

without this change the test fails because the redirect loop fails to trigger the limit

mock.push(
Response::builder()
.status(StatusCode::FOUND)
Expand Down
3 changes: 2 additions & 1 deletion src/gcp/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,8 @@ mod tests {
let err = GoogleCloudStorageBuilder::new()
.with_service_account_path(service_account_path.to_str().unwrap())
.with_bucket_name("foo")
.with_proxy_url("asdf://example.com")
// use invalid url
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

.with_proxy_url("dxx:ddd\\example.com")
.build()
.unwrap_err()
.to_string();
Expand Down