-
Notifications
You must be signed in to change notification settings - Fork 102
Chore: fix emulator tests due to changes in reqwest #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -622,7 +622,7 @@ mod tests { | |
| assert_eq!(r.status(), StatusCode::OK); | ||
|
|
||
| // Handles redirect loop | ||
| for _ in 0..10 { | ||
| for _ in 0..11 { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this change is needed due to seanmonstar/reqwest#2664 without this change the test fails because the redirect loop fails to trigger the limit |
||
| mock.push( | ||
| Response::builder() | ||
| .status(StatusCode::FOUND) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -674,7 +674,8 @@ mod tests { | |
| let err = GoogleCloudStorageBuilder::new() | ||
| .with_service_account_path(service_account_path.to_str().unwrap()) | ||
| .with_bucket_name("foo") | ||
| .with_proxy_url("asdf://example.com") | ||
| // use invalid url | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
| .with_proxy_url("dxx:ddd\\example.com") | ||
| .build() | ||
| .unwrap_err() | ||
| .to_string(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect, but don't know, that this change is required by
the test expects the proxy config to fail, but after the reqwest upgrade it was passing