Chore: fix emulator tests due to changes in reqwest #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 5, 2025
|
|
||
| // Handles redirect loop | ||
| for _ in 0..10 { | ||
| for _ in 0..11 { |
Contributor
Author
There was a problem hiding this comment.
I believe this change is needed due to seanmonstar/reqwest#2664
without this change the test fails because the redirect loop fails to trigger the limit
| .with_bucket_name("bucket_name") | ||
| .with_allow_http(true) | ||
| .with_proxy_url("asdf://example.com") | ||
| // use invalid url |
Contributor
Author
There was a problem hiding this comment.
I suspect, but don't know, that this change is required by
the test expects the proxy config to fail, but after the reqwest upgrade it was passing
| .with_service_account_path(service_account_path.to_str().unwrap()) | ||
| .with_bucket_name("foo") | ||
| .with_proxy_url("asdf://example.com") | ||
| // use invalid url |
This was referenced Jun 5, 2025
Merged
tustvold
approved these changes
Jun 6, 2025
mbrobbel
approved these changes
Jun 6, 2025
Contributor
Author
AdamGS
pushed a commit
to AdamGS/arrow-rs-object-store
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The CI tests started failing on main
I tracked the issue down to starting with the releas of reqwest
0.12.16: https://crates.io/crates/reqwest/0.12.16See the changelog here: https://github.com/seanmonstar/reqwest/releases/tag/v0.12.16
What changes are included in this PR?
Are there any user-facing changes?