feat:Configure plug-ins to support this feature #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2647 +/- ##
==========================================
- Coverage 76.49% 67.98% -8.52%
==========================================
Files 139 39 -100
Lines 3748 1040 -2708
Branches 872 268 -604
==========================================
- Hits 2867 707 -2160
+ Misses 881 333 -548
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Baoyuantop
reviewed
Oct 21, 2022
Comment on lines
+71
to
+72
| "eslint-plugin-import": "^2.26.0", | ||
| "eslint-plugin-simple-import-sort": "^8.0.0", |
There was a problem hiding this comment.
Are both of these required? I think eslint-plugin-import is enough
There was a problem hiding this comment.
Because I think it can auto fix import order problem.I try to use only eslint-plugin-import but no work.
| globals: { | ||
| ANT_DESIGN_PRO_ONLY_DO_NOT_USE_IN_YOUR_PRODUCTION: true, | ||
| page: true, | ||
| REACT_APP_ENV: true, | ||
| }, | ||
| rules: { | ||
| '@typescript-eslint/naming-convention': 'off', | ||
| 'import/no-unresolved': [2, { ignore: ['^@/', '^umi/', '^@@/'] }], | ||
| 'sort-imports': 'off', | ||
| 'import/order': 'off', |
There was a problem hiding this comment.
Avoid conflict and according to simple-import-sort.
There was a problem hiding this comment.
Both parts of the modification look fine.
|
Also cc @SkyeYoung PTAL |
SkyeYoung
approved these changes
Oct 24, 2022
Baoyuantop
approved these changes
Oct 26, 2022
hongbinhsu
added a commit
to fitphp/apix-dashboard
that referenced
this pull request
Nov 7, 2022
* upstream/master: fix: change default CSP value (apache#2601) fix: ant-table unable to request (apache#2641) fix: plugin_config missing on service exist (apache#2657) feat: add etcd store auto re-initialize (apache#2650) feat: add login filter of OpenID-Connect (apache#2608) feat:Configure plug-ins to support this feature (apache#2647) feat: Adding a Loading state to buttons (apache#2630) feat: dashboard support windows (apache#2619) Feat: add tip and preset model for plugin editor, improve e2e stability (apache#2581) docs: add Slack invitation link badge (apache#2617) # Conflicts: # .github/workflows/backend-cli-test.yml # Dockerfile # api/test/shell/cli_test.sh # web/src/components/Footer/index.tsx # web/src/components/RightContent/index.tsx # web/src/pages/ServerInfo/List.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
I try to configure the two plug-ins to format the import and export.
Related issues
fix/resolve #2646
Checklist: