feat: dashboard support windows #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2619 +/- ##
==========================================
+ Coverage 70.99% 76.23% +5.23%
==========================================
Files 119 139 +20
Lines 3275 3694 +419
Branches 800 872 +72
==========================================
+ Hits 2325 2816 +491
+ Misses 950 878 -72
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@guoqqqi @Baoyuantop @bzp2010 @SkyeYoung Use node.js is better than 'cp' in implementing the copy command, which can also be run on Windows, which will provide more support for dashboard |
|
Please make CI pass, thanks. |
8 tasks
@Baoyuantop @guoqqqi @bzp2010 @SkyeYoung All test cases of Dashboard have been repaired and passed, and the issue#2615 can be closed.
|
SkyeYoung
approved these changes
Sep 30, 2022
Baoyuantop
approved these changes
Sep 30, 2022
|
Hello, @FangSen9000 Can you help to resolve the conficts |
hongbinhsu
added a commit
to fitphp/apix-dashboard
that referenced
this pull request
Nov 7, 2022
* upstream/master: fix: change default CSP value (apache#2601) fix: ant-table unable to request (apache#2641) fix: plugin_config missing on service exist (apache#2657) feat: add etcd store auto re-initialize (apache#2650) feat: add login filter of OpenID-Connect (apache#2608) feat:Configure plug-ins to support this feature (apache#2647) feat: Adding a Loading state to buttons (apache#2630) feat: dashboard support windows (apache#2619) Feat: add tip and preset model for plugin editor, improve e2e stability (apache#2581) docs: add Slack invitation link badge (apache#2617) # Conflicts: # .github/workflows/backend-cli-test.yml # Dockerfile # api/test/shell/cli_test.sh # web/src/components/Footer/index.tsx # web/src/components/RightContent/index.tsx # web/src/pages/ServerInfo/List.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
It is better to use node.js to implement the copy command than cp, which can also be run on Windows.
Related issues
Checklist: