-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support proto API #2099
feat: support proto API #2099
Conversation
44eea86
to
781fa52
Compare
Codecov Report
@@ Coverage Diff @@
## master #2099 +/- ##
===========================================
- Coverage 69.34% 50.39% -18.96%
===========================================
Files 188 40 -148
Lines 7161 3072 -4089
Branches 823 0 -823
===========================================
- Hits 4966 1548 -3418
+ Misses 1906 1330 -576
+ Partials 289 194 -95
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Do you have any suggestions on compiling and verifying the correctness of |
fe4339f
to
d9a69be
Compare
Hi, everyone. This is some information about the current PR. Complete status:
Current limitations:Now I haven't found a way to integrate the protobuf golang generator into the program, so I can't verify the protobuf entered by the user in real time and point out the error. Need help:I wonder if you have a better way. If so, please point it out and I will continue to improve it. |
Hi @ShiningRush @shuaijinchao, any ideas about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the PR is too big. We could split it into several small PRs.
Yes, I think so. I will try it. BTW, should I split to function, unit test, e2e test, that 3 PRs? |
We could split it to: |
adaa0bd
to
3dee8dd
Compare
3dee8dd
to
6facb43
Compare
ping @nic-chen |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Add
proto
entity support to Manager API.Related issues
resolve part of #1378 #1449
Checklist: