Skip to content

Commit

Permalink
feat: support proto API (#2099)
Browse files Browse the repository at this point in the history
  • Loading branch information
bzp2010 authored Oct 19, 2021
1 parent 5065c65 commit 9f17637
Show file tree
Hide file tree
Showing 8 changed files with 629 additions and 0 deletions.
14 changes: 14 additions & 0 deletions .github/workflows/backend-e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ jobs:
--set *.cache-from=type=local,src=/tmp/.buildx-cache \
--set *.cache-to=type=local,dest=/tmp/.buildx-cache
- name: build and start grpc_server_example
working-directory: ./api/test/docker
run: |
wget https://github.com/api7/grpc_server_example/archive/refs/tags/20210819.tar.gz
tar -xzvf 20210819.tar.gz && cd grpc_server_example-20210819
docker build -t grpc_server_example:latest .
- name: run docker compose
working-directory: ./api/test/docker
run: |
Expand Down Expand Up @@ -171,6 +178,13 @@ jobs:
--set *.cache-from=type=local,src=/tmp/.buildx-cache \
--set *.cache-to=type=local,dest=/tmp/.buildx-cache
- name: build and start grpc_server_example
working-directory: ./api/test/docker
run: |
wget https://github.com/api7/grpc_server_example/archive/refs/tags/20210819.tar.gz
tar -xzvf 20210819.tar.gz && cd grpc_server_example-20210819
docker build -t grpc_server_example:latest .
- name: run docker compose
working-directory: ./api/test/docker
run: |
Expand Down
260 changes: 260 additions & 0 deletions api/internal/handler/proto/proto.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,260 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package proto

import (
"context"
"encoding/json"
"errors"
"fmt"
"net/http"
"reflect"
"strings"

"github.com/gin-gonic/gin"
"github.com/shiningrush/droplet"
"github.com/shiningrush/droplet/data"
"github.com/shiningrush/droplet/wrapper"
wgin "github.com/shiningrush/droplet/wrapper/gin"

"github.com/apisix/manager-api/internal/core/entity"
"github.com/apisix/manager-api/internal/core/store"
"github.com/apisix/manager-api/internal/handler"
"github.com/apisix/manager-api/internal/utils"
)

type Handler struct {
routeStore store.Interface
serviceStore store.Interface
consumerStore store.Interface
pluginConfigStore store.Interface
globalRuleStore store.Interface
protoStore store.Interface
}

func NewHandler() (handler.RouteRegister, error) {
return &Handler{
routeStore: store.GetStore(store.HubKeyRoute),
serviceStore: store.GetStore(store.HubKeyService),
consumerStore: store.GetStore(store.HubKeyConsumer),
pluginConfigStore: store.GetStore(store.HubKeyPluginConfig),
globalRuleStore: store.GetStore(store.HubKeyGlobalRule),
protoStore: store.GetStore(store.HubKeyProto),
}, nil
}

func (h *Handler) ApplyRoute(r *gin.Engine) {
r.GET("/apisix/admin/proto/:id", wgin.Wraps(h.Get,
wrapper.InputType(reflect.TypeOf(GetInput{}))))
r.GET("/apisix/admin/proto", wgin.Wraps(h.List,
wrapper.InputType(reflect.TypeOf(ListInput{}))))
r.POST("/apisix/admin/proto", wgin.Wraps(h.Create,
wrapper.InputType(reflect.TypeOf(entity.Proto{}))))
r.PUT("/apisix/admin/proto", wgin.Wraps(h.Update,
wrapper.InputType(reflect.TypeOf(UpdateInput{}))))
r.PUT("/apisix/admin/proto/:id", wgin.Wraps(h.Update,
wrapper.InputType(reflect.TypeOf(UpdateInput{}))))
r.PATCH("/apisix/admin/proto/:id", wgin.Wraps(h.Patch,
wrapper.InputType(reflect.TypeOf(PatchInput{}))))
r.PATCH("/apisix/admin/proto/:id/*path", wgin.Wraps(h.Patch,
wrapper.InputType(reflect.TypeOf(PatchInput{}))))
r.DELETE("/apisix/admin/proto/:ids", wgin.Wraps(h.BatchDelete,
wrapper.InputType(reflect.TypeOf(BatchDeleteInput{}))))
}

var plugins = []string{"grpc-transcode"}

type GetInput struct {
ID string `auto_read:"id,path" validate:"required"`
}

func (h *Handler) Get(c droplet.Context) (interface{}, error) {
input := c.Input().(*GetInput)

r, err := h.protoStore.Get(c.Context(), input.ID)
if err != nil {
return handler.SpecCodeResponse(err), err
}

return r, nil
}

type ListInput struct {
Desc string `auto_read:"desc,query"`
store.Pagination
}

func (h *Handler) List(c droplet.Context) (interface{}, error) {
input := c.Input().(*ListInput)

ret, err := h.protoStore.List(c.Context(), store.ListInput{
Predicate: func(obj interface{}) bool {
if input.Desc != "" {
return strings.Contains(obj.(*entity.Proto).Desc, input.Desc)
}
return true
},
PageSize: input.PageSize,
PageNumber: input.PageNumber,
})
if err != nil {
return nil, err
}

return ret, nil
}

func (h *Handler) Create(c droplet.Context) (interface{}, error) {
input := c.Input().(*entity.Proto)

// check proto id exist
if input.ID != nil {
protoID := utils.InterfaceToString(input.ID)
ret, err := h.protoStore.Get(c.Context(), protoID)
if err != nil && err != data.ErrNotFound {
return handler.SpecCodeResponse(err), err
}
if ret != nil {
return &data.SpecCodeResponse{StatusCode: http.StatusBadRequest}, errors.New("proto id exists")
}
}

// create
ret, err := h.protoStore.Create(c.Context(), input)
if err != nil {
return handler.SpecCodeResponse(err), err
}

return ret, nil
}

type UpdateInput struct {
ID string `auto_read:"id,path"`
entity.Proto
}

func (h *Handler) Update(c droplet.Context) (interface{}, error) {
input := c.Input().(*UpdateInput)

// check if ID in body is equal ID in path
if err := handler.IDCompare(input.ID, input.Proto.ID); err != nil {
return &data.SpecCodeResponse{StatusCode: http.StatusBadRequest}, err
}

if input.ID != "" {
input.Proto.ID = input.ID
}

res, err := h.protoStore.Update(c.Context(), &input.Proto, true)
if err != nil {
return handler.SpecCodeResponse(err), err
}

return res, nil
}

type PatchInput struct {
ID string `auto_read:"id,path"`
SubPath string `auto_read:"path,path"`
Body []byte `auto_read:"@body"`
}

func (h *Handler) Patch(c droplet.Context) (interface{}, error) {
input := c.Input().(*PatchInput)
reqBody := input.Body
id := input.ID
subPath := input.SubPath

stored, err := h.protoStore.Get(c.Context(), id)
if err != nil {
return handler.SpecCodeResponse(err), err
}

res, err := utils.MergePatch(stored, subPath, reqBody)

if err != nil {
return handler.SpecCodeResponse(err), err
}

var proto entity.Proto
if err := json.Unmarshal(res, &proto); err != nil {
return handler.SpecCodeResponse(err), err
}

ret, err := h.protoStore.Update(c.Context(), &proto, false)
if err != nil {
return handler.SpecCodeResponse(err), err
}

return ret, nil
}

type BatchDeleteInput struct {
IDs string `auto_read:"ids,path"`
}

func (h *Handler) BatchDelete(c droplet.Context) (interface{}, error) {
input := c.Input().(*BatchDeleteInput)

ids := strings.Split(input.IDs, ",")
checklist := []store.Interface{h.routeStore, h.consumerStore, h.serviceStore, h.pluginConfigStore, h.globalRuleStore}

for _, id := range ids {
for _, store := range checklist {
if err := h.checkProtoUsed(c.Context(), store, id); err != nil {
return handler.SpecCodeResponse(err), err
}
}
}

if err := h.protoStore.BatchDelete(c.Context(), ids); err != nil {
return handler.SpecCodeResponse(err), err
}

return nil, nil
}

func (h *Handler) checkProtoUsed(ctx context.Context, storeInterface store.Interface, key string) error {
ret, err := storeInterface.List(ctx, store.ListInput{
Predicate: func(obj interface{}) bool {
record := obj.(entity.GetPlugins)
for _, plugin := range plugins {
if _, ok := record.GetPlugins()[plugin]; ok {
configs := record.GetPlugins()[plugin].(map[string]interface{})
protoId := utils.InterfaceToString(configs["proto_id"])
if protoId == key {
return true
}
}
}
return false
},
Format: func(obj interface{}) interface{} {
return obj.(entity.GetPlugins)
},
PageSize: 0,
PageNumber: 0,
})
if err != nil {
return err
}
if ret.TotalSize > 0 {
return fmt.Errorf("proto used check invalid: %s: %s is using this proto", storeInterface.Type(), ret.Rows[0].(entity.GetBaseInfo).GetBaseInfo().ID)
}
return nil

}
47 changes: 47 additions & 0 deletions api/internal/handler/proto/proto_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package proto

import (
"encoding/json"
"testing"

"github.com/stretchr/testify/assert"

"github.com/apisix/manager-api/internal/core/entity"
)

func TestStructUnmarshal(t *testing.T) {
// define and parse data
jsonStr := `{
"id": 1,
"create_time": 1700000000,
"update_time": 1700000000,
"desc": "desc",
"content": "content"
}`
proto := entity.Proto{}
err := json.Unmarshal([]byte(jsonStr), &proto)

// asserts
assert.Nil(t, err)
assert.Equal(t, proto.ID, float64(1))
assert.Equal(t, proto.CreateTime, int64(1700000000))
assert.Equal(t, proto.UpdateTime, int64(1700000000))
assert.Equal(t, proto.Desc, "desc")
assert.Equal(t, proto.Content, "content")
}
2 changes: 2 additions & 0 deletions api/internal/route.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import (
"github.com/apisix/manager-api/internal/handler/label"
"github.com/apisix/manager-api/internal/handler/migrate"
"github.com/apisix/manager-api/internal/handler/plugin_config"
"github.com/apisix/manager-api/internal/handler/proto"
"github.com/apisix/manager-api/internal/handler/route"
"github.com/apisix/manager-api/internal/handler/schema"
"github.com/apisix/manager-api/internal/handler/server_info"
Expand Down Expand Up @@ -77,6 +78,7 @@ func SetUpRouter() *gin.Engine {
tool.NewHandler,
plugin_config.NewHandler,
migrate.NewHandler,
proto.NewHandler,
}

for i := range factories {
Expand Down
10 changes: 10 additions & 0 deletions api/test/docker/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,16 @@ services:
apisix_dashboard_e2e:
ipv4_address: 172.16.238.20

upstream_grpc:
image: grpc_server_example
restart: always
ports:
- '50051:50051'
- '50052:50052'
networks:
apisix_dashboard_e2e:
ipv4_address: 172.16.238.21

apisix:
hostname: apisix_server1
image: apache/apisix:2.10.0-alpine
Expand Down
1 change: 1 addition & 0 deletions api/test/e2enew/base/base.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ var (
token string

UpstreamIp = "172.16.238.20"
UpstreamGrpcIp = "172.16.238.21"
APISIXHost = "http://127.0.0.1:9080"
APISIXInternalUrl = "http://172.16.238.30:9080"
APISIXSingleWorkerHost = "http://127.0.0.1:9081"
Expand Down
Loading

0 comments on commit 9f17637

Please sign in to comment.