[AMBARI-22194] Remove accidental jline.internal.Log import #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While reviewing #493, I was looking for how Ambari Server uses the
jline:jlinedependency, and found that it only appears once. This single usage was added in c19f363, I believe accidentally, probably as a last minute change, since it is not part of the reviewed patch.I'd like to replace it with the regular slf4j logger, since the jline one is not properly initialized and simply logs to
System.err.(Note that
jline:jlineis a transitive dependency, so it is not being removed here. However, if this change is accepted, then #493 won't need to add it as explicit dependency.)CC @smolnar82
How was this patch tested?
Artificially triggered the exception, compared outputs without and with the change.
Before,
ambari-server.out:After,
ambari-server.log: