[AMBARI-23093] Eliminated the org.apache.zookeeper:zookeeper dependency due to security concerns #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y due to security concerns
Contributor
Author
|
@rlevas @zeroflag @dlysnichenko @adoroszlai Please review this PR; thanks! |
|
Refer to this link for build results (access rights to CI server needed): |
ghost
approved these changes
Feb 28, 2018
rlevas
approved these changes
Feb 28, 2018
adoroszlai
approved these changes
Feb 28, 2018
| </dependency> | ||
| <dependency> | ||
| <groupId>jline</groupId> | ||
| <artifactId>jline</artifactId> |
Contributor
There was a problem hiding this comment.
This no longer needs to be added.
Contributor
Author
There was a problem hiding this comment.
Will remove it from trunk version
ambari-server/pom.xml
Outdated
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.apache.curator</groupId> | ||
| <artifactId>curator-framework</artifactId> |
Contributor
There was a problem hiding this comment.
Spacing seems wrong here.
ambari-server/pom.xml
Outdated
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.apache.zookeeper</groupId> | ||
| <artifactId>zookeeper</artifactId> |
ambari-server/pom.xml
Outdated
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.apache.zookeeper</groupId> | ||
| <artifactId>zookeeper</artifactId> |
Contributor
Author
|
Can someone please merge it? Thanks! |
smolnar82
changed the title
Contributor
Author
|
Thanks @adoroszlai! |
|
Refer to this link for build results (access rights to CI server needed): |
mpapirkovskyy
pushed a commit
to mpapirkovskyy/ambari
that referenced
this pull request
Apr 12, 2019
…y due to security concerns (apache#493) (cherry picked from commit ccd31b6) Change-Id: I4cfa6952e737dedc44b840145f4971d396f19f18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Per CVE-2016-5017
Per CVE-2017-5637
So that I eliminated
org.apache.zookeper:zookeeperfromambari-server's build (it was never directly referenced; it's been a transitive dependency). However I needed to add a direct dependency ofjline:jline(we already have a managed version of this library inambari-project).How was this patch tested?
After updating the affected pom.xml files I've done the following:
1.) Checking Maven's dependency resolution:
2.) I executed
mvn clean testinambari-server:3.) In addition to this; I replaced the content of
usr/lib/ambari-serverin my vagrant host with the content fromambari-server/target/ambari-server-2.6.0.0.0-dist/usr/lib/ambari-server(where there was no zookeeper.jar) and restarted the server; logged in and did some actions (in this case I added created a cluster (HDFS only) via blueprints and then added Zookeeper); there were no any issues.