Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dag graph with nested groups and join_ids #44199

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Nov 19, 2024

Add Graph view in a full modal to the Dag page. This is just mock data because the API endpoint is not done yet issue

Nov-19-2024 15-47-44

Done:

  • stores modal state in url params
  • renders a graph
  • handles join nodes
  • can expand/collapse groups which are stored in localStorage
  • Setup/teardown tasks
  • Mapped tasks
  • Edge labels

To Do:

  • Task information
  • Task Instance information
  • Selecting a node
  • Tests
  • Filtering upstream/downstream
  • External deps (assets, sensors, triggers)
  • Zoomed out
  • Highlighting tasks by state

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 19, 2024
@bbovenzi
Copy link
Contributor Author

Nested task groups, setup/teardown, mapped tasks, edge labels:

Screenshot 2024-11-19 at 5 56 47 PM

@bbovenzi bbovenzi marked this pull request as ready for review November 20, 2024 15:11
@jscheffl
Copy link
Contributor

Mhm, I don't know what is wrong in my env...wanted to test but ANY DAG that I call is showing the same "wrong" view and I can also not click/scroll the elements.
Ubuntu with Firefox and Chrome. Both the same. Dark and light mode.

image

@jscheffl
Copy link
Contributor

Mhm, I don't know what is wrong in my env...wanted to test but ANY DAG that I call is showing the same "wrong" view and I can also not click/scroll the elements. Ubuntu with Firefox and Chrome. Both the same. Dark and light mode.

Mhm, okay. It is better in dev-mode. But the DAG graph displayed is static and not matching to selected DAG. Is is a technical mock atm?

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Nov 20, 2024

Mhm, okay. It is better in dev-mode. But the DAG graph displayed is static and not matching to selected DAG. Is is a technical mock atm?

Yes, I just updated the description to say that this is all mocked data since the API endpoint isn't done yet

@pierrejeambrun
Copy link
Member

@jscheffl

In non dev-mode do you still have the issue mentioned above ?

@bbovenzi
Copy link
Contributor Author

No, I'm able to replicate the non-dev mode issue. I'm looking into it

@bbovenzi
Copy link
Contributor Author

Fixed!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both in dev-mode and non dev-mode. Working as expected.

Just a couple of minor suggestions. The code is looking good :)

airflow/ui/src/pages/DagsList/Dag/Graph/Edge.tsx Outdated Show resolved Hide resolved
airflow/ui/src/pages/DagsList/Dag/Graph/Graph.tsx Outdated Show resolved Hide resolved
@bbovenzi bbovenzi merged commit 5a0272c into apache:main Nov 21, 2024
37 checks passed
@bbovenzi bbovenzi deleted the new-ui-graph branch November 21, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants