-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dag graph with nested groups and join_ids #44199
Conversation
Mhm, okay. It is better in dev-mode. But the DAG graph displayed is static and not matching to selected DAG. Is is a technical mock atm? |
Yes, I just updated the description to say that this is all mocked data since the API endpoint isn't done yet |
In non |
No, I'm able to replicate the non-dev mode issue. I'm looking into it |
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both in dev-mode and non dev-mode. Working as expected.
Just a couple of minor suggestions. The code is looking good :)
2306cb4
to
25e2e9d
Compare
Add Graph view in a full modal to the Dag page. This is just mock data because the API endpoint is not done yet issue
Done:
To Do:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.