Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 Add external dependencies to a dag's graph_data #42367

Open
1 task done
pierrejeambrun opened this issue Sep 20, 2024 · 3 comments
Open
1 task done

AIP-84 Add external dependencies to a dag's graph_data #42367

pierrejeambrun opened this issue Sep 20, 2024 · 3 comments
Assignees
Labels
AIP-84 Modern Rest API area:datasets Issues related to the datasets feature area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests kind:meta High-level information important to the community

Comments

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Sep 20, 2024

from @bbovenzi:

In 2.10, we cobbled together a UI to show dataset conditions and upstream and downstream dataset dependencies. We should update this to include a boolean param show_external_dependencies to show connected datasets, dataset conditions, triggers and sensors.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@pierrejeambrun pierrejeambrun added kind:meta High-level information important to the community AIP-84 Modern Rest API labels Sep 20, 2024
@dosubot dosubot bot added area:datasets Issues related to the datasets feature area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests labels Sep 20, 2024
@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 2, 2024

We can rename graph_data to dag structure, with edges and nodes. The nested list of nodes should have the topological sort, which we may move to happen during DAG serialization. With a sorted list of nodes, specifying which are tasks and which aren't, we can reuse the endpoint to help render the grid and gantt views.

@bbovenzi
Copy link
Contributor

bbovenzi commented Nov 5, 2024

Actually, the sort should be based off of the webserver.grid_view_sorting_order config.

@bbovenzi bbovenzi changed the title AIP-84 Add external dependencies to a dag's graph_data #931 AIP-84 Add external dependencies to a dag's graph_data Nov 15, 2024
@pierrejeambrun pierrejeambrun self-assigned this Nov 18, 2024
@bbovenzi
Copy link
Contributor

bbovenzi commented Nov 19, 2024

Updated types I am using on the frontend mockups:

export type Edge = {
  is_setup_teardown?: boolean;
  label?: string;
  source_id: string;
  target_id: string;
};

export type Node = {
  children?: Array<Node>;
  id: string;
  is_mapped?: boolean;
  label: string;
  tooltip?: string;
  setup_teardown_type?: "setup" | "teardown";
  type:
    | "asset_alias"
    | "asset_condition"
    | "asset"
    | "dag"
    | "join"
    | "sensor"
    | "task"
    | "trigger";
};

export type GraphData = {
  arrange: "BT" | "LR" | "RL" | "TB";
  edges: Array<Edge>;
  nodes: Array<Node>;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-84 Modern Rest API area:datasets Issues related to the datasets feature area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests kind:meta High-level information important to the community
Projects
Development

No branches or pull requests

2 participants