Hide logical date and run id in trigger UI form#35284
Merged
jscheffl merged 9 commits intoNov 8, 2023
Merged
Conversation
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
boring-cyborg
Bot
added
area:UI
jscheffl
changed the title
Member
|
I like it. No good knowledge to comment on the code, but the ideas here are good. |
Contributor
|
Nice. Thanks @jscheffl 👍 |
Member
|
Congraulations on your first (!?) merged PR as committer @jscheffl :D |
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
* Move Run ID and Logical Date into hidden section, layout fixes * Make DAG docs display per default in trigger DAG UI * Update UI Screenshot in docs * Add form elements to legacy form as well --------- Co-authored-by: Jens Scheffler <95105677+jens-scheffler-bosch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an improvement based on the feedback raised in issue #34726 and optimizes the layout of the trigger UI form.
This PR changes:
AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=Trueis setHow to test?
example_params_ui_tutorialand check the formAIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=Trueand trigger the DAGexample_python_operatorwith configUI Before:
UI After:
DAG Options when un-folded lower section:
closes: #34726