Simplify DAG trigger UI#34567
Merged
Merged
Conversation
We don't need to show details on how to access dagrun conf on the trigger page every time - DAG authors can find it in the docs. Also, don't show the "unpause dag" toggle if the DAG is already unpaused - no matter your choice it'll unpaused.
jedcunningham
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
Bot
added
area:UI
bbovenzi
approved these changes
Sep 22, 2023
Contributor
|
Cool, just found this change by adding another PR as "beautification" in #35284 - congrats to this cool PR ID! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to show details on how to access dagrun conf on the trigger page every time - DAG authors can find it in the docs.
Also, don't show the "unpause dag" toggle if the DAG is already unpaused - no matter your choice it'll unpaused.
Before:
After - DAG Unpaused:
After - DAG Paused: