Skip to content

Fix refuse_to_run_test_from_wrongly_named_files to handle system tests #32655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ferruzzi merged 1 commit into from
Jul 17, 2023
Merged

Fix refuse_to_run_test_from_wrongly_named_files to handle system tests #32655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,8 +909,16 @@ def clear_lru_cache():

@pytest.fixture(autouse=True)
def refuse_to_run_test_from_wrongly_named_files(request):
dirname: str = request.node.fspath.dirname
filename: str = request.node.fspath.basename
if not request.node.fspath.basename.startswith("test_"):
is_system_test: bool = "tests/system/" in dirname
if is_system_test and not request.node.fspath.basename.startswith("example_"):
raise Exception(
f"All test method files in tests/system must start with 'example_'. Seems that {filename} "
f"contains {request.function} that looks like a test case. Please rename the file to "
f"follow the example_* pattern if you want to run the tests in it."
)
if not is_system_test and not request.node.fspath.basename.startswith("test_"):
raise Exception(
f"All test method files in tests/ must start with 'test_'. Seems that {filename} "
f"contains {request.function} that looks like a test case. Please rename the file to "
Expand Down