Skip to content

Conversation

@vincbeck
Copy link
Contributor

A check has been added in #32626 to enforce all test file names to be test_*. System tests are not named test_* but example_*. As a result, any attempt to execute a system test will fail. See AWS system tests dashboard: https://aws-mwaa.github.io/open-source/system-tests/dashboard.html.

This PR handles the system tests and enforce all system test file names to follow the pattern example_*.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vincbeck vincbeck added the use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing) label Jul 17, 2023
@vincbeck
Copy link
Contributor Author

Closing the PR and re-open it with use-public-runners label. Tests are not picked up

@vincbeck vincbeck closed this Jul 17, 2023
@vincbeck vincbeck reopened this Jul 17, 2023
@potiuk
Copy link
Member

potiuk commented Jul 17, 2023

Full tests needed is the right label for it

@potiuk potiuk added full tests needed We need to run full set of tests for this PR to merge and removed use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing) labels Jul 17, 2023
@potiuk potiuk closed this Jul 17, 2023
@potiuk potiuk reopened this Jul 17, 2023
@o-nikolas
Copy link
Contributor

Full tests needed is the right label for it

@potiuk Does "Full tests needed" run on public runners? The issue we were trying to avoid is that it's actually quite annoying to be placed on the self hosted/committers workers, since the queuing is broken there it seems.

@potiuk
Copy link
Member

potiuk commented Jul 17, 2023

Full tests needed is the right label for it

@potiuk Does "Full tests needed" run on public runners? The issue we were trying to avoid is that it's actually quite annoying to be placed on the self hosted/committers workers, since the queuing is broken there it seems.

I see it's runnnig all right? What's broken? I've been away and on mobile most of the day, something happened?

@o-nikolas
Copy link
Contributor

Full tests needed is the right label for it

@potiuk Does "Full tests needed" run on public runners? The issue we were trying to avoid is that it's actually quite annoying to be placed on the self hosted/committers workers, since the queuing is broken there it seems.

I see it's runnnig all right? What's broken? I've been away and on mobile most of the day, something happened?

Just the same thing as always, jobs getting stuck in queued since the autoscaling is wonky for self hosted runners (re this Slack thread).

@ferruzzi
Copy link
Contributor

FWIW I ran into this over here as well, where the tests just stayed queued. I bumped them to a public runner since it's a small docs change and they ran fine after adding that tag.

@potiuk
Copy link
Member

potiuk commented Jul 17, 2023

Still waiting for someone to migrate to k8s operator if GitHub

@ferruzzi ferruzzi merged commit 6064a6e into apache:main Jul 17, 2023
@vincbeck vincbeck deleted the vincbeck/fix-test-name-check branch July 17, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants