-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix refuse_to_run_test_from_wrongly_named_files to handle system tests #32655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
Closing the PR and re-open it with |
|
Full tests needed is the right label for it |
@potiuk Does "Full tests needed" run on public runners? The issue we were trying to avoid is that it's actually quite annoying to be placed on the self hosted/committers workers, since the queuing is broken there it seems. |
I see it's runnnig all right? What's broken? I've been away and on mobile most of the day, something happened? |
Just the same thing as always, jobs getting stuck in queued since the autoscaling is wonky for self hosted runners (re this Slack thread). |
|
FWIW I ran into this over here as well, where the tests just stayed queued. I bumped them to a public runner since it's a small docs change and they ran fine after adding that tag. |
|
Still waiting for someone to migrate to k8s operator if GitHub |
A check has been added in #32626 to enforce all test file names to be
test_*. System tests are not namedtest_*butexample_*. As a result, any attempt to execute a system test will fail. See AWS system tests dashboard: https://aws-mwaa.github.io/open-source/system-tests/dashboard.html.This PR handles the system tests and enforce all system test file names to follow the pattern
example_*.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.