Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator #31657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vandonr-amz
reviewed
Jun 7, 2023
ferruzzi
reviewed
Jun 7, 2023
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Left a few non-binding suggestions.
…ateProfileOperator Unit tests for both
Raise Error from Trigger rather than a TriggerEvent in case of failure Other minor fixes
syedahsn
force-pushed
the
syedahsn/deferrable-eks-fargate-profile
branch
from
fd4df6c to
93dce0d
Compare
o-nikolas
approved these changes
Jun 14, 2023
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
Browsed the code quickly, and there are some other reviews/approvals. Merging this one, we can always circle back later
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows deferrable mode to be used with the
EksCreateFargateProfileOperatorand theEksDeleteFargateProfileOperator. It also includes unit tests to test the triggers for both of the operators.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.