Add deferrable option to EmrTerminateJobFlowOperator #31646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vandonr-amz
reviewed
Jun 7, 2023
Contributor
There was a problem hiding this comment.
&& same remarks as on #31657 for the trigger:
- no need to cache hook
- should raise error directly
syedahsn
requested review from
Fokko,
XD-DENG,
ashb,
bbovenzi,
dstandish,
ephraimbuddy,
jedcunningham,
jhtimmins,
josh-fell,
kaxil,
mik-laj,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
syedahsn
force-pushed
the
syedahsn/deferrable-emr-terminate-job-flow
branch
from
7788400 to
90338fb
Compare
Contributor
Author
|
Sorry for tagging everyone in the PR. I messed up my commits 😅 |
syedahsn
force-pushed
the
syedahsn/deferrable-emr-terminate-job-flow
branch
from
bfefcbf to
757e718
Compare
Add unit tests
…erminateJobFlowOperator Add EmrTerminateJobFlowTrigger to provider.yaml Address PR comments
Raise error directly from Trigger
syedahsn
force-pushed
the
syedahsn/deferrable-emr-terminate-job-flow
branch
from
849cda4 to
6422a38
Compare
o-nikolas
approved these changes
Jun 15, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deferrable mode for
EmrTerminateJobFlowOperatoras well as the associated tests.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.