Add pre-commit to check that aiobotocore is an optional dependency #31023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
Member
Author
|
We do not want to check it manually, we alredy got it accidentally merged once for the last amazon's provider's release And we could have easily repeat the mistake: #31018 |
pankajkoti
approved these changes
May 2, 2023
eladkal
reviewed
May 2, 2023
potiuk
force-pushed
the
check-aibotocore-is-optional
branch
from
33b2199 to
87e8890
Compare
ferruzzi
approved these changes
May 3, 2023
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
I also like that you added all providers, just to protect us against Transfers accidentally including it. 👍
o-nikolas
approved these changes
May 4, 2023
potiuk
force-pushed
the
check-aibotocore-is-optional
branch
from
87e8890 to
b9972ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.