Add deferrable mode for S3KeySensor #31018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
pankajastro
reviewed
May 2, 2023
Member
|
@ferruzzi @o-nikolas @vincbeck -> your feedback is welcome :) |
Contributor
|
CC @syedahsn for when you're back |
vincbeck
requested changes
May 18, 2023
vincbeck
requested changes
May 29, 2023
pankajastro
reviewed
May 29, 2023
ephraimbuddy
approved these changes
Jun 7, 2023
phanikumv
approved these changes
Jun 7, 2023
ephraimbuddy
reviewed
Jun 7, 2023
ephraimbuddy
reviewed
Jun 7, 2023
vandonr-amz
reviewed
Jun 7, 2023
vandonr-amz
reviewed
Jun 7, 2023
jedcunningham
approved these changes
Jun 8, 2023
Comment on lines
+24
to
+26
| from airflow.providers.amazon.aws.triggers.s3 import ( | ||
| S3KeyTrigger, | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| from airflow.providers.amazon.aws.triggers.s3 import ( | |
| S3KeyTrigger, | |
| ) | |
| from airflow.providers.amazon.aws.triggers.s3 import S3KeyTrigger |
nit
Contributor
There was a problem hiding this comment.
So sorry. Didn't see this. Was on mobile
86 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR donates the following
S3KeySensorwith a deferrable mode, waiting for one or multiple keys (a file-like instance on S3) to be in an S3 bucket. This was developed in astronomer-providers repository to apache-airflow.cc: @phanikumv
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.