Fix KubernetesExecutor sending state to scheduler #30872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the event_buffer expects the TI state, not the worker state. This changes KE to sending the proper state back to the scheduler job.
boring-cyborg
bot
added
provider:cncf-kubernetes
jedcunningham
requested review from
XD-DENG,
ashb,
dstandish and
kaxil
as code owners
ephraimbuddy
approved these changes
Apr 26, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Fix KubernetesExecutor sending state to scheduler It turns out the event_buffer expects the TI state, not the worker state. This changes KE to sending the proper state back to the scheduler job. * dedup using event, not running (cherry picked from commit 0133f68)
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the event_buffer expects the TI state, not the worker state. This changes KE to sending the proper state back to the scheduler job.
Related: #28871