KubenetesExecutor sends state even when successful #28871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the other executors, KubernetesExecutor should send the "worker state" back to result buffer. This is more consistent, particularly around logging, with the other executors.
boring-cyborg
bot
added
provider:cncf-kubernetes
uranusjr
reviewed
Jan 12, 2023
o-nikolas
approved these changes
Jan 12, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
approved these changes
Jan 13, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 6, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 8a9959c)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 8a9959c)
64 tasks
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the other executors, KubernetesExecutor should send the "worker
state" back to result buffer. This is more consistent, particularly
around logging, with the other executors.
This allows for the
TaskInstance Finishedlog line to be populated for KE like it is for other executors.