Rename most pod_id usage to pod_name in KubernetesExecutor #29147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
jedcunningham
commented
Jan 25, 2023
jedcunningham
force-pushed
the
ke_pod_id_to_pod_name
branch
from
4a84b0c to
fc14f9f
Compare
jedcunningham
force-pushed
the
ke_pod_id_to_pod_name
branch
from
fc14f9f to
7b51994
Compare
potiuk
approved these changes
Feb 19, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
I think we are close to - or already agreed to - getting the "definition" of Public - so for me this one is "OK" to rename those.
jedcunningham
force-pushed
the
ke_pod_id_to_pod_name
branch
from
7b51994 to
8904fec
Compare
jedcunningham
commented
Apr 11, 2023
Member
|
Can't rebase it, but it's good to go after resolving conflicts I guess :) |
We were using pod_id in a lot of place, where really it is just the pod name. I've renamed it, where it is easy to do so, so things are easier to follow.
jedcunningham
force-pushed
the
ke_pod_id_to_pod_name
branch
from
4f2d043 to
3b82343
Compare
potiuk
approved these changes
Apr 22, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 26, 2023
We were using pod_id in a lot of place, where really it is just the pod name. I've renamed it, where it is easy to do so, so things are easier to follow. (cherry picked from commit 5efcb99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using pod_id in a lot of place, where really it is just the pod name. I've renamed it, where it is easy to do so, so things are easier to follow.