fix(core): don't add metrics to query object when in raw records mode#995
fix(core): don't add metrics to query object when in raw records mode#995
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/3Wd5Hz3n77VcSgo6aZV56gjv9qpV |
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
==========================================
- Coverage 27.90% 27.90% -0.01%
==========================================
Files 413 414 +1
Lines 8510 8512 +2
Branches 1199 1205 +6
==========================================
Hits 2375 2375
- Misses 5982 5983 +1
- Partials 153 154 +1
Continue to review full report at Codecov.
|
ktmud
changed the title
| description?: string | null; | ||
| expression?: string | null; | ||
| database_expression?: string | null; | ||
| python_date_format?: string | null; |
There was a problem hiding this comment.
Consolidate types from Column and ColumnMeta.
| columns: [], | ||
| metrics: [], | ||
| orderby: [], | ||
| orderby: undefined, |
There was a problem hiding this comment.
Should we test when metrics and/or orderby are not set too?
There was a problem hiding this comment.
Some existing tests already covered this.
ktmud
force-pushed
the
raw-records-no-metrics
branch
from
f5c2a8d to
b2e158b
Compare
2 participants
🏆 Enhancements
🐛 Bug Fix
Don't set
metricsin QueryObject is it is in raw records mode. Then we can assume it is an aggregation query as long asmetricsis defined, even if it's just empty array.This allows a clean deprecation of the
groupbyfield.See discussions in apache/superset#13434 for details.