Skip to content
This repository was archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-table): metrics should be undefined#1005

Merged
ktmud merged 3 commits intomasterfrom
table-raw-records-empty-metrics
Mar 12, 2021
Merged

fix(plugin-chart-table): metrics should be undefined#1005
ktmud merged 3 commits intomasterfrom
table-raw-records-empty-metrics

Conversation

@ktmud
Copy link
Contributor

@ktmud ktmud commented Mar 12, 2021

🐛 Bug Fix

Metrics should be undefined when table chart is in raw records mode.

I changed the logic of buildQuery in @superset-ui/core, but failed to update the one in table chart itself.

Related to #995

ktmud added 2 commits March 12, 2021 11:40
Metrics should be `undefined` in raw records mode.
@ktmud ktmud requested a review from a team as a code owner March 12, 2021 19:51
@vercel
Copy link

vercel bot commented Mar 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/HhajAXi3yePkcBSnvRBQqxJoZDR2
✅ Preview: https://superset-ui-git-table-raw-records-empty-metrics-superset.vercel.app

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #1005 (7840859) into master (00d2ad6) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
- Coverage   27.89%   27.88%   -0.01%     
==========================================
  Files         414      414              
  Lines        8522     8523       +1     
  Branches     1210     1211       +1     
==========================================
  Hits         2377     2377              
  Misses       5989     5989              
- Partials      156      157       +1     
Impacted Files Coverage Δ
plugins/plugin-chart-table/src/buildQuery.ts 61.70% <50.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d2ad6...7840859. Read the comment docs.

@ktmud ktmud merged commit 753563c into master Mar 12, 2021
@ktmud ktmud deleted the table-raw-records-empty-metrics branch March 12, 2021 22:02
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants