This repository was archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-table): metrics should be undefined#1005
Merged
Conversation
Metrics should be `undefined` in raw records mode.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/HhajAXi3yePkcBSnvRBQqxJoZDR2 |
kristw
approved these changes
Mar 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 27.89% 27.88% -0.01%
==========================================
Files 414 414
Lines 8522 8523 +1
Branches 1210 1211 +1
==========================================
Hits 2377 2377
Misses 5989 5989
- Partials 156 157 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Metrics should be
undefinedwhen table chart is in raw records mode.I changed the logic of
buildQueryin@superset-ui/core, but failed to update the one in table chart itself.Related to #995