Skip to content

feature-set-interface: Use it in the sdk#86

Closed
joncinque wants to merge 2 commits intoanza-xyz:masterfrom
joncinque:sdkfeatureset
Closed

feature-set-interface: Use it in the sdk#86
joncinque wants to merge 2 commits intoanza-xyz:masterfrom
joncinque:sdkfeatureset

Conversation

@joncinque
Copy link
Copy Markdown
Collaborator

@joncinque joncinque commented Mar 25, 2025

Problem

solana-feature-set-interface was added to decouple the feature ids from the sdk, but it still isn't used in any of the sdk crates.

Summary of changes

Use solana-feature-set-interface everywhere. Note that this requires some redefinitions of feature ids from solana-feature-set.

@joncinque
feature-set-interface: Use it in the sdk
6f3b198 
#### Problem

solana-feature-set-interface was added to decouple the feature ids from
the sdk, but it still isn't used in any of the sdk crates.

#### Summary of changes

Use `solana-feature-set-interface` everywhere. Note that this requires
some redefinitions of feature ids from `solana-feature-set`.
@joncinque joncinque requested a review from t-nelson March 25, 2025 21:23
@joncinque joncinque requested a review from jstarry March 26, 2025 13:05
@joncinque joncinque mentioned this pull request Mar 26, 2025
Closed
jstarry
jstarry reviewed Mar 26, 2025
View reviewed changes
Comment thread ed25519-program/src/lib.rs
pub const SIGNATURE_OFFSETS_START: usize = 2;
pub const DATA_START: usize = SIGNATURE_OFFSETS_SERIALIZED_SIZE + SIGNATURE_OFFSETS_START;

/// Copy from agave-feature-set
Copy link
Copy Markdown
Contributor

@jstarry jstarry Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is exactly what I was trying to avoid in #85. By doing this we are coupling sdk crate versions to runtime releases in a way that will be really tricky to track, especially for rekeys.

Copy link
Copy Markdown
Collaborator Author

@joncinque joncinque Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's totally fair!

@joncinque
Copy link
Copy Markdown
Collaborator Author

joncinque commented Mar 26, 2025

Closing in favor of anza-xyz/agave#5509

@joncinque joncinque closed this Mar 26, 2025
febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 8, 2025
@SITADRITA1 @febo
Fix Grammar and Typographical Errors in Documentation (anza-xyz#86)
3581524 
* Update README.md

* Update README.md

* Update README.md
febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 8, 2025
@SITADRITA1 @febo
Fix Grammar and Typographical Errors in Documentation (anza-xyz#86)
31d0955 
* Update README.md

* Update README.md

* Update README.md
febo added a commit that referenced this pull request Oct 9, 2025
@febo @rex4539
@SITADRITA1 @osrm @LucasSte @sonicfromnewyoke @joncinque
program-log: Add new crate (#356)
c14ab07 
* Lightweight log macro (#32)

* Add log standalone crate

* Refactored

* Fix return value

* Remove additional crate

* Tidy up

* Use memcpy

* Improve digit formatting

* Improve slice formatting

* Improve comments

* Add readme

* Update README.md

* Update README.md

* Remove doctests

* Use workspace values

* Added linked readme

* Add precision formatting (#47)

* Add precision argument

* Add std feature

* Add std feature cfg

* Add precision to solana target

* Add precision support for signed types

* Add inline

* Update docs

* Fix slice offset

* Fix delta for signed values

* Fix doc tests

* Add precision formatting to `log!` macro (#50)

* Add precision formatting

* Remove lazy lock

* Add precision formatting details

* Update banner image

* Add subtitle

* log: Add precision support to `str` (#51)

* Bump version

* Inline never

* Add precision support to str

* Add trucated attributes

* macro: Add truncate formatting (#52)

* Add truncate format parsing

* Add formatting options

* Update README.md

* Bump log version

* Add formatting examples

* Update banner image

* Update banner image

* Add crate type

* log: Add support for `usize` and `isize` (#69)

* Fix typo

* Add support for usize and isize

* Improve sign conversion

* Add tests

* Simplify isize handling

* Avoid duplicate crates (#74)

* Avoid duplicate crates

* Fix vulnerable package

* Fix Grammar and Typographical Errors in Documentation (#86)

* Update README.md

* Update README.md

* Update README.md

* Address review comments (#78)

* [wip]: Address review comments

* [wip]: Fix pointer reference

* [wip]: Add logger buffer size tests

* Remove unused

* More logger tests

* Rename program to cpi

* Remove dynamic allocation

* Fixed signed tests

* Fix review comments

* Fix unsigned test case

* Add is_owner_by helper

* Update README layout (#100)

* Update readme

* Add docs

* Fix link

* chore: Release

* chore: Release

* log: Use alloc crate (#120)

Use alloc

* Publish pinocchio-log-macro v0.4.1

* Add rust version to crates (#135)

Add rust version

* chore: fix typos (#150)

fix typos README.md

* log: Improve digit logic (#155)

Tweaks

* log: Add support for `bool` type (#156)

* Tweaks

* Add bool support

* Use static syscalls when available (#157)

* fix: make `sol_log_` call public (#168)

* fix: make sol_log_ call public

* fix: logger formatting

* feat: add`log_cu_usage` proc_macro_attribute (#162)

* feat: add compute_fn proc_macro_attribute

* WIP: use sol_remaining_compute_units syscall for calc

* docs: actualize docs and add introspection cost comment

* refactor: add static-syscall, remove dep on pinocchio from log, rename compute_fn -> log_cu_usage

* fix: correct comment

* fix: ci format step

* log: Add unsafe to Log trait (#186)

Add unsafe

* log: Calculate maximum digits for `Log` implementation (#188)

* Calculate max digits

* Remove second const

Co-authored-by: Jon C <me@jonc.dev>

---------

Co-authored-by: Jon C <me@jonc.dev>

* ci: Add spellcheck step (#164)

* Add invoke instruction helper

* Typos

* Remove new helpers

* Remove unused

* Address review comments

* Tweak inline attributes

* Use invoke signed unchecked

* Refactor inline

* Renamed to with_bounds

* Update docs

* Revert change

* Add constant length check

* Add spellcheck step

* Tweak action

* Fix typos

* More fixes

* Yet more fixes

* Fixes

* Add j1 option

* More and more fixes

* Add missing acronym

* Fix merge

* Fix spelling

* Fix spelling

* Publish pinocchio-log-macro v0.5.0

* Publish pinocchio-log v0.5.0

* log: Update precision logic (#252)

* Add precision cap

* Add tests

* Refactor precision logic

* Fix miri warning

* Avoid duplication

* Add missing syscall

* More tests

* Fix truncate logic

* Fix review comments

* Publish pinocchio-log v0.5.1

* Add solana-program-log

* Add no_std check

* Fix formatting

* Fix formatting

Updated README to correct links and improve formatting.

* Add std support

* Fix docs

* Fix nits

* Bump regex dependency

* Tweak std feature

* Move macro to top-level

* Move dependency to workspace

* Update nits

---------

Co-authored-by: Dimitris Apostolou <dimitris.apostolou@icloud.com>
Co-authored-by: SITADRITA1 <mrlime2018@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: osrm <90407222+osrm@users.noreply.github.com>
Co-authored-by: Lucas Ste <38472950+LucasSte@users.noreply.github.com>
Co-authored-by: Sonic <sonic.from.new.yoke@gmail.com>
Co-authored-by: Jon C <me@jonc.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-nelson t-nelson Awaiting requested review from t-nelson

1 more reviewer

@jstarry jstarry jstarry left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joncinque @jstarry