Add AbiExample for dashmap and boxcar#188
Conversation
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just a nit on the declared version, which you can take or leave
| blake3 = "1.5.5" | ||
| borsh = { version = "1.5.5", features = ["derive", "unstable__schema"] } | ||
| borsh0-10 = { package = "borsh", version = "0.10.3" } | ||
| boxcar = "0.2.7" |
There was a problem hiding this comment.
I know this is coming from an older PR, but any reason to not use the newest version which is committed to the lockfile?
There was a problem hiding this comment.
no reason! I'll update
|
Thanks for reviewing! So... what now? Do we need to make a release to unblock anza-xyz/agave#3796 ? |
|
That's correct, you can typically just publish the crate yourself using the GitHub Action. In this case, I did it for you -- enjoy! https://crates.io/crates/solana-frozen-abi/2.3.0 A bit more info at https://github.com/anza-xyz/solana-sdk?tab=readme-ov-file#publishing-a-crate-from-this-repository |
Needed to pick up anza-xyz/solana-sdk#188
* Calculate max digits * Remove second const Co-authored-by: Jon C <me@jonc.dev> --------- Co-authored-by: Jon C <me@jonc.dev>
* Calculate max digits * Remove second const Co-authored-by: Jon C <me@jonc.dev> --------- Co-authored-by: Jon C <me@jonc.dev>
* Lightweight log macro (#32) * Add log standalone crate * Refactored * Fix return value * Remove additional crate * Tidy up * Use memcpy * Improve digit formatting * Improve slice formatting * Improve comments * Add readme * Update README.md * Update README.md * Remove doctests * Use workspace values * Added linked readme * Add precision formatting (#47) * Add precision argument * Add std feature * Add std feature cfg * Add precision to solana target * Add precision support for signed types * Add inline * Update docs * Fix slice offset * Fix delta for signed values * Fix doc tests * Add precision formatting to `log!` macro (#50) * Add precision formatting * Remove lazy lock * Add precision formatting details * Update banner image * Add subtitle * log: Add precision support to `str` (#51) * Bump version * Inline never * Add precision support to str * Add trucated attributes * macro: Add truncate formatting (#52) * Add truncate format parsing * Add formatting options * Update README.md * Bump log version * Add formatting examples * Update banner image * Update banner image * Add crate type * log: Add support for `usize` and `isize` (#69) * Fix typo * Add support for usize and isize * Improve sign conversion * Add tests * Simplify isize handling * Avoid duplicate crates (#74) * Avoid duplicate crates * Fix vulnerable package * Fix Grammar and Typographical Errors in Documentation (#86) * Update README.md * Update README.md * Update README.md * Address review comments (#78) * [wip]: Address review comments * [wip]: Fix pointer reference * [wip]: Add logger buffer size tests * Remove unused * More logger tests * Rename program to cpi * Remove dynamic allocation * Fixed signed tests * Fix review comments * Fix unsigned test case * Add is_owner_by helper * Update README layout (#100) * Update readme * Add docs * Fix link * chore: Release * chore: Release * log: Use alloc crate (#120) Use alloc * Publish pinocchio-log-macro v0.4.1 * Add rust version to crates (#135) Add rust version * chore: fix typos (#150) fix typos README.md * log: Improve digit logic (#155) Tweaks * log: Add support for `bool` type (#156) * Tweaks * Add bool support * Use static syscalls when available (#157) * fix: make `sol_log_` call public (#168) * fix: make sol_log_ call public * fix: logger formatting * feat: add`log_cu_usage` proc_macro_attribute (#162) * feat: add compute_fn proc_macro_attribute * WIP: use sol_remaining_compute_units syscall for calc * docs: actualize docs and add introspection cost comment * refactor: add static-syscall, remove dep on pinocchio from log, rename compute_fn -> log_cu_usage * fix: correct comment * fix: ci format step * log: Add unsafe to Log trait (#186) Add unsafe * log: Calculate maximum digits for `Log` implementation (#188) * Calculate max digits * Remove second const Co-authored-by: Jon C <me@jonc.dev> --------- Co-authored-by: Jon C <me@jonc.dev> * ci: Add spellcheck step (#164) * Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Revert change * Add constant length check * Add spellcheck step * Tweak action * Fix typos * More fixes * Yet more fixes * Fixes * Add j1 option * More and more fixes * Add missing acronym * Fix merge * Fix spelling * Fix spelling * Publish pinocchio-log-macro v0.5.0 * Publish pinocchio-log v0.5.0 * log: Update precision logic (#252) * Add precision cap * Add tests * Refactor precision logic * Fix miri warning * Avoid duplication * Add missing syscall * More tests * Fix truncate logic * Fix review comments * Publish pinocchio-log v0.5.1 * Add solana-program-log * Add no_std check * Fix formatting * Fix formatting Updated README to correct links and improve formatting. * Add std support * Fix docs * Fix nits * Bump regex dependency * Tweak std feature * Move macro to top-level * Move dependency to workspace * Update nits --------- Co-authored-by: Dimitris Apostolou <dimitris.apostolou@icloud.com> Co-authored-by: SITADRITA1 <mrlime2018@gmail.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: Lucas Ste <38472950+LucasSte@users.noreply.github.com> Co-authored-by: Sonic <sonic.from.new.yoke@gmail.com> Co-authored-by: Jon C <me@jonc.dev>
Needed by anza-xyz/agave#3796