SIMD-406: Restrict to 255 the number of accounts in instructions for transactions v0 and legacy#520
Closed
LucasSte wants to merge 1 commit into
Closed
SIMD-406: Restrict to 255 the number of accounts in instructions for transactions v0 and legacy#520LucasSte wants to merge 1 commit into
LucasSte wants to merge 1 commit into
Conversation
jstarry
suggested changes
Jan 9, 2026
| /// - All values are within their static max/min bounds. | ||
| pub trait Sanitize { | ||
| fn sanitize(&self) -> Result<(), SanitizeError> { | ||
| fn sanitize(&self, _limit_ix_accounts_simd_406: bool) -> Result<(), SanitizeError> { |
Contributor
There was a problem hiding this comment.
There are a lot of things in the agave repo that implement this trait so I don't think it's a good idea to change this trait method. Check out anza-xyz/agave#8182 for another approach that doesn't involve changing the Sanitize trait. After these features are activated we can update the Sanitize implementation in the SDK without a boolean for the feature.
Contributor
Author
There was a problem hiding this comment.
Thanks for the hint. I'll follow an approach similar to the PR you pointed.
Contributor
Author
|
Superseded by anza-xyz/agave#10223. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SIMD-406, we proposed that v0 and legacy transaction sanitization must now have an extra check to limit the number of accounts per instruction to 255.
This PR implements this check behind a boolean flag that will be coupled with a feature gate in Agave.