Skip to content

SIMD-0160: static instruction limit#8182

Merged
tao-stones merged 5 commits into
anza-xyz:masterfrom
tao-stones:feat/simd-0160-static-instruction-limit-feautre-gated
Sep 30, 2025
Merged

SIMD-0160: static instruction limit#8182
tao-stones merged 5 commits into
anza-xyz:masterfrom
tao-stones:feat/simd-0160-static-instruction-limit-feautre-gated

Conversation

@tao-stones
Copy link
Copy Markdown

Problem

Issue #8181 for SIMD-0160

Summary of Changes

  • Add feature gate to start apply limit to transaction's top level instructions during sanitization.

Fixes #8181

@tao-stones tao-stones requested a review from a team as a code owner September 24, 2025 22:31
Comment thread runtime/src/bank.rs Outdated
@tao-stones tao-stones force-pushed the feat/simd-0160-static-instruction-limit-feautre-gated branch 2 times, most recently from 977bde5 to 37f5e5f Compare September 25, 2025 16:16
@tao-stones tao-stones force-pushed the feat/simd-0160-static-instruction-limit-feautre-gated branch from 37f5e5f to 286793e Compare September 25, 2025 16:29
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 98.91304% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.0%. Comparing base (84c5f28) to head (b13051f).
⚠️ Report is 2096 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8182    +/-   ##
========================================
  Coverage    83.0%    83.0%            
========================================
  Files         827      827            
  Lines      362713   362853   +140     
========================================
+ Hits       301254   301389   +135     
- Misses      61459    61464     +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread feature-set/src/lib.rs
}

pub mod static_instruction_limit {
solana_pubkey::declare_id!("64ixypL1HPu8WtJhNSMb9mSgfFaJvsANuRkTbHyuLfnx");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

64ix 🫡

Comment thread runtime/src/bank.rs
@mergify
Copy link
Copy Markdown

mergify Bot commented Sep 26, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @tao-stones.

@tao-stones tao-stones requested a review from apfitzge September 29, 2025 15:08
Copy link
Copy Markdown

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it's own this PR does not support the transition into the feature correctly, but since #8183 has already been merged it seems this will work as intended.

My thought here was that RuntimeTransaction/SanitizedTransactionView types are not sufficient because we create these values ahead of time and store until we become leader. If ingested before the activation these can get past the filters of this PR for block-production, and a leader could include them. However, since #8183 we do not even reach this stage and they are dropped before we get here.

@tao-stones tao-stones merged commit 096ef63 into anza-xyz:master Sep 30, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Gate: Static Instruction Limit

3 participants