transaction: re-export types used in public API#296
Merged
joncinque merged 5 commits intoanza-xyz:masterfrom Aug 26, 2025
Merged
transaction: re-export types used in public API#296joncinque merged 5 commits intoanza-xyz:masterfrom
joncinque merged 5 commits intoanza-xyz:masterfrom
Conversation
joncinque
reviewed
Aug 26, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just the question about InstructionError
joncinque
approved these changes
Aug 26, 2025
Contributor
|
Also just want to say I appreciate your clean commits on these, it does make it easier to review! |
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 21, 2025
* re-export essential types in solana-transaction * re-export transaction error types and don't alias TransactionResult in crate * re-export solana-signer items * switch to solana-address * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and switch to solana-address