Skip to content

rpc-client-types: re-export types used in public API and switch to solana-address#7737

Merged
joncinque merged 4 commits intoanza-xyz:masterfrom
kevinheavey:rpc-client-types-reexports
Aug 29, 2025
Merged

rpc-client-types: re-export types used in public API and switch to solana-address#7737
joncinque merged 4 commits intoanza-xyz:masterfrom
kevinheavey:rpc-client-types-reexports

Conversation

@kevinheavey
Copy link
Copy Markdown

Similar to anza-xyz/solana-sdk#296

These types are returned or used by public code in solana-rpc-client-types, so re-exporting them adds convenience and helps avoid confusion over version mismatches without increasing the API surface area

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.1%. Comparing base (4a3e05a) to head (4a37340).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7737   +/-   ##
=======================================
  Coverage    83.0%    83.1%           
=======================================
  Files         812      812           
  Lines      356900   356900           
=======================================
+ Hits       296578   296594   +16     
+ Misses      60322    60306   -16     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevinheavey kevinheavey changed the title transaction: re-export types used in public API and switch to solana-address rpc-client-types: re-export types used in public API and switch to solana-address Aug 27, 2025
@kevinheavey kevinheavey requested a review from joncinque August 27, 2025 13:30
@joncinque joncinque added the CI Pull Request is ready to enter CI label Aug 29, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Aug 29, 2025
Copy link
Copy Markdown

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@joncinque
Copy link
Copy Markdown

Maybe this needs to be rebased? I don't totally understand the source of the error

@kevinheavey kevinheavey force-pushed the rpc-client-types-reexports branch from 637f819 to 4a37340 Compare August 29, 2025 09:41
@joncinque
Copy link
Copy Markdown

Thanks for the contribution!

@joncinque joncinque merged commit d240fe5 into anza-xyz:master Aug 29, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants