solana-quic-definitions: remove useless consts#294
Closed
alexpyattaev wants to merge 2 commits intoanza-xyz:masterfrom
Closed
solana-quic-definitions: remove useless consts#294alexpyattaev wants to merge 2 commits intoanza-xyz:masterfrom
alexpyattaev wants to merge 2 commits intoanza-xyz:masterfrom
Conversation
alexpyattaev
force-pushed
the
cleanup_quic_definitions
branch
from
7cf664f to
1d7a0b8
Compare
alexpyattaev
changed the title
Collaborator
|
Closing since quic-definitions was totally removed with #541 |
Contributor
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need the QUIC window size constants since we do not explicitly control the window size in bytes anymore after anza-xyz/agave#9143 was merged.
Similarly QUIC_PORT_OFFSET is not needed anymore after anza-xyz/agave#9757 was mergerd.
This breaks public API and requires a major version bump for solana-quic-definitions crate.